-
-
Notifications
You must be signed in to change notification settings - Fork 7k
feat(typescript-angular): add util "provideApi" and update docs to standalone applications #21173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ular 17 and above)
…ngular applications
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) Would be great to get a review / feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for your contribution, looks good!
please address the comments, then we can merge it.
modules/openapi-generator/src/main/resources/typescript-angular/README.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-angular/provide-api.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-angular/provide-api.mustache
Outdated
Show resolved
Hide resolved
@jase88 sorry for the long delay with the review |
No need to apologize. I won't be able to adjust the MR until next week as I don't have access to my laptop right now |
@macjohnny I applied the suggestions you made :) |
# Conflicts: # samples/client/petstore/rust/hyper/test-duplicates/docs/Vehicle.md # samples/client/petstore/rust/hyper/test-duplicates/docs/another_test.md # samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Duplicatetest.md # samples/client/petstore/rust/reqwest/petstore-async/docs/Duplicatetest.md # samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/Duplicatetest.md # samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Duplicatetest.md # samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooDuplicatetest.md # samples/client/petstore/rust/reqwest/petstore/docs/Duplicatetest.md # samples/client/petstore/rust/reqwest/test-duplicates/docs/Vehicle.md # samples/client/petstore/rust/reqwest/test-duplicates/docs/another_test.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
provideApi
for standalone Angular applications (introduced in Angular v17 and now the default for new projects).fixes #20884
relates #17031
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)